Open zmughal opened 1 year ago
The patch
utility distributed with 5.38.0.1 (and 5.36.1.1) is built without any additional patching. The one distributed with 5.32.1.1 and earlier had some patches applied as part of its build.
Possibly we should apply one or more of the previous SP and MSYS2 patches.
https://github.com/StrawberryPerl/build-extlibs/blob/master/patches/patch-2.7.5/patch-2.7.5.diff https://github.com/msys2/MSYS2-packages/blob/master/patch/msys2-patch-2.7.1.patch https://github.com/msys2/MSYS2-packages/blob/master/patch/msys2-patch-manifest.patch
Issue transferred to the build-extlibs repo given that's where the code is.
I have built patch
with the MSYS and Strawberry Perl patches listed in https://github.com/StrawberryPerl/build-extlibs/issues/51#issuecomment-1646350068
It still does not work. In some cases it silently fails to make changes.
Unless someone knows of additional patches for the build, the simplest approach would seem to be to use a patch.exe
from elsewhere.
The MSYS2 patch works but depends on msys-2.0.dll
. The chocolatey patch.exe
is version 2.5.9, which is the same as the numeric version that comes with SP 5.32 so presumably won't handle recent diff formats (https://github.com/StrawberryPerl/Perl-Dist-Strawberry/issues/74). That needs to be tested, though.
When trying to apply a patch,
patch
gives the error:It appears to apply when there is a directory prefix, so for the above, a workaround is to do
-d src -p2
to remove thea/src/
part.Test case:
Commands:
The following is a transcript with StrawberryPerl 5.38.1's
patch.exe
:The following is a transcript with StrawberryPerl 5.32.1.1's
patch.exe
:Connects with https://github.com/StrawberryPerl/Perl-Dist-Strawberry/issues/74.