StreamController / DeckPlugin

GNU General Public License v3.0
1 stars 0 forks source link

Adjusting Brightness with Deck plugin doesn't seem to modify brightness within StreamController #8

Open KaJe5380 opened 4 months ago

KaJe5380 commented 4 months ago

Describe the bug

I keep a settings page for my SteamDeck+ to adjust brightness and force sleep with the Deck Plugin. However I notice that it does not save this brightness within StreamController application itself. This means that once a user changes the page; it will go back to whatever brightness is within StreamController Settings.

This bug happens whether or not Page Settings and Overwrite default deck screensaver or Overwrite default deck brightness is enabled.

This happens with both actions: Adjust Brightness and Set Brightness.

Deck Plugin, Adjust Brightness bug

To Reproduce

Page settings overrides don't matter. Why? Because another issue is that Deck setting brightness overrides the very own Overwrite default deck brightness. I will open an issue of this on StreamController itself.

  1. Have a page with an action with either adjust brightness or set brightness.
    • My adjust brightness either increments by +10 or -10 with a min of 5.
    • My set brightness is just to 50
  2. Deck Settings, I have brightness at 4. Barely visible but makes this bug very apparent.
  3. Adjust or set brightness
  4. Change page

Expected behavior

Deck Plugin's adjust brightness and set brightness should be able to modify StreamController's brightness setting, so that page changes don't override said issue.

Screenshots

Deck Settings

image

Page Setup

image image image image image

Additional context

Tested on a StreamDeck+

This is my Linux outputted via FastFetch within Konsole: image

Core447 commented 4 months ago

This is actually the intended behavior, but I get that it might be weird. I'll add an option to let the action store the change