StreamController / OBSPlugin

GNU General Public License v3.0
3 stars 5 forks source link

fix: proper error handling #2

Closed Sorunome closed 5 months ago

Sorunome commented 5 months ago

Together with https://github.com/StreamController/StreamController/pull/122 this will remove the message spam and properly update the icon label to be an error label

Core447 commented 5 months ago

Thank you very much! However, I don't see how this affects the command line output, or what spamming do you mean?

Sorunome commented 5 months ago

Together without https://github.com/StreamController/StreamController/pull/122 it was spamming the log greatly. Additionally, the error icon wasn't handled properly and the backend object was created too early

    1. 2024 21:00:53 Core447 @.***>:

Thank you very much! However, I don't see how this affects the command line output, or what spamming do you mean?

— Reply to this email directly, view it on GitHub[https://github.com/StreamController/OBSPlugin/pull/2#issuecomment-2140689805], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVBNSADZYNZIGGGWCMTZE5ZNVAVCNFSM6AAAAABIQXT7H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBQGY4DSOBQGU]. You are receiving this because you authored the thread. [Sledovací obrázek][https://github.com/notifications/beacon/AASSEVFUVZE5EDWIFWVAZI3ZE5ZNVA5CNFSM6AAAAABIQXT7H2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT7TBKY2.gif]

Core447 commented 5 months ago

As for the too early call of launch_backend, this was a problem that I fixed in the app. I'm going to add the hide_error manually if this ok? You can also open a new PR with just that if you want to

Sorunome commented 5 months ago

yup, sounds good. not sure if that will work with the current stable release, though

    1. 2024 13:28:50 Core447 @.***>:

As for the too early call of launch_backend, this was a problem that I fixed in the app. I'm going to add the hide_error manually if this ok? You can also open a new PR with just that if you want to

— Reply to this email directly, view it on GitHub[https://github.com/StreamController/OBSPlugin/pull/2#issuecomment-2143811076], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASSEVBOQ2GFPMLBT34GWZ3ZFL6WRAVCNFSM6AAAAABIQXT7H2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBTHAYTCMBXGY]. You are receiving this because you authored the thread. [Sledovací obrázek][https://github.com/notifications/beacon/AASSEVACA54OJLLDDMTA7PDZFL6WRA5CNFSM6AAAAABIQXT7H2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT7Y73AI.gif]

Core447 commented 5 months ago

yup, sounds good. not sure if that will work with the current stable release, though

It should work, because the error was added after the release

Core447 commented 5 months ago

Added the self.hide_error() line in 24ed6eda83d3397fd7551179dd8c48e27decae0a