search

StreamController / Requests

GNU General Public License v3.0
2 stars 2 forks source link

Feat: requet with more Http-Methods and reply types #3

Open GsakuL opened 3 months ago

GsakuL commented 3 months ago

I'm still working on it, but it's a bit more than expected at first. I'm creating this draft as some "sort of sign" that work is being done, just a bit slow. I have other stuff going on, so it's not for a lack of trying.

This currently seems to work, but I have not tested every Http-Method and every reply. I also think it's kinda messy, even though I've tried to split this sensibly.

I've based MultiRequest on GetRequest. I thought about replacing it, but I'm not sure if that's ok. If there are Migrators for Plugin settings, I could add one (for PostRequest and GetRequest) , since MultiRequest is supposed to be to handle "all of that and more".

Also unit tests would be nice, but that is itself a big task.

Input from anyone is welcome. However I intend to refactor a bunch to make it easier to read/understand, so smaller comments might be irrelevant later.

but in the end, this would then resolve #2

Core447 commented 3 months ago

Nice work! I'll try it when I have some time

Core447 commented 2 months ago

I've based MultiRequest on GetRequest. I thought about replacing it, but I'm not sure if that's ok. If there are Migrators for Plugin settings, I could add one (for PostRequest and GetRequest) , since MultiRequest is supposed to be to handle "all of that and more".

Unfortunately there are no migrators atm, but maybe we can write something manually for the plugin or keep the old actions around for now