search

StreamHPC / gromacs

OpenCL porting of the GROMACS molecular simulation toolkit
http://www.gromacs.org
Other
25 stars 4 forks source link

Refactor JIT support #83

Closed mabraham closed 9 years ago

mabraham commented 9 years ago

JIT compilation was being done earlier than needed, but some reorganization of the existing Gromacs is needed to move the compilation to a place where call graphs and module dependencies flow more smoothly.

Related, some code has moved from data_mgmt to generic nbnxn_gpu files, because they were not really about data management.

mabraham commented 9 years ago

This logic is used twice by opencl, unlike CUDA, so if you want to propose removing the function, please suggest how to remove one of the code paths.

The name could indeed be improved - I was focused on how to achieve the reorganization. Perhaps you should check the header file for the documentation, since that's the usual practice in Gromacs. ;-)

pszi1ard commented 9 years ago

Sorry, I overlooked the second call.

I only see a brief doc in the header which is nearly as brief as the function name itself (minus underscores plus word auto-completion :).