search

StreamMachine / prometheus_client_nodejs

Prometheus metrics client for Node.js
Apache License 2.0
30 stars 16 forks source link

not using Prometheus naming conventions #10

Open askmike opened 8 years ago

askmike commented 8 years ago

Great project! In the hope that this is still maintained: the metrics exposed are not using prometheus naming conventions:

A counter MUST have the following methods:

  • inc(): Increment the counter by 1
  • inc(double v): Increment the counter by the given amount. MUST check that v >= 0.

While this lib exposes increment. Also the decrease does not obey the convention:

It MUST NOT allow the value to decrease