search

StreamMeDev / hermes

A react message input with autocomplete and other handy features
ISC License
6 stars 0 forks source link

Updated to React 16, react & friends are peer dependencies #13

Closed nicorobo closed 6 years ago

wesleytodd commented 6 years ago

Same comment as in flyout. The prop-types in the peer deps should be >15.0.0. There is some question about making that not a peer dep and having it just be a normal run-time dep which can load multiple versions. But I think it is reasonable to leave it as a peer dep until it becomes an issue.

nicorobo commented 6 years ago

@wesleytodd Okay, I'll change those. Is this something we want to begin doing for all of our peer dependencies?

wesleytodd commented 6 years ago

My guess is yes. These react packages are really already installed and used in all of our services. And I am guessing in anyone who would use these packages. So making them really flexible ranges in peer deps is the simplest way which does not cause file size bloat by having multiple versions.