No ctrl shortcuts by default

StreamMeDev / hermes

A react message input with autocomplete and other handy features

ISC License

6 stars 0 forks source link

No ctrl shortcuts by default #15

Closed Jeddf closed 6 years ago

Jeddf commented 6 years ago

resolve #14

wesleytodd commented 6 years ago

Probably best to make this configurable. Would be simple enough to add a new prop which turns them off.

Jeddf commented 6 years ago

I can't see anyone ever wanting the ctrl-c shortcut in a website, it means any copy operation done in windows with ctrl-c also clears all the text. I'll make a new PR just removing the ctrl-c shortcut.

wesleytodd commented 6 years ago

As I mentioned in the other issue, a windows user might expect escape to do the same thing as ctrl-c. So I would figure out how to support both and switch based on platform.