In production, we noticed a steady increase in memory usage until our nodes would crash due to out of memory. Using valgrind and the pastebin below via valgrind --leak-check=full node --expose-gc beamcoder.js, we discovered what appears to be memory leaks in the decoder, encoder, and filters due to frames and packets not being freed. This PR adds the necessary av_frame_free and av_packet_free calls to avoid this memory leak. Apologies if the code is not ideal. I don't work in C++ day to day
Description
In production, we noticed a steady increase in memory usage until our nodes would crash due to out of memory. Using valgrind and the pastebin below via
valgrind --leak-check=full node --expose-gc beamcoder.js
, we discovered what appears to be memory leaks in the decoder, encoder, and filters due to frames and packets not being freed. This PR adds the necessaryav_frame_free
andav_packet_free
calls to avoid this memory leak. Apologies if the code is not ideal. I don't work in C++ day to dayhttps://pastebin.com/Q2fCP4qa