Closed daveyijzermans closed 1 year ago
Thanks very much for your pull request! I have another request for Mac support as well so I hope to be able to consider your merge shortly as part of making grandiose truly multi-platform. We have several other multi-platform Node bindings.
Support for linux has been merged in #18
Hi! Came across your package and wanted to use it on Linux, but it didn't include the Linux libraries. So I've tried to include them and make it work, and I think it does, at least I tested it on Debian Stretch. I also checked that my changes didn't break Windows support.
If you want to merge my changes go ahead, although I made some additions in src/grandiose_util.cc and src/grandiose_send.cc that were for some reason required on my system. Namely: the sin function wasn't defined without including cmath, and I had to include an overloaded itoa function (I got it from somewhere else) because again my Debian system didn't include that non-standard function.
So those 'fixes' probably aren't pretty but for now it works, in my environment. Hope this helps you in some part, I'm not skilled at C++ so I could only hack this together to get it working.
Thanks!