search

Streampunk / sdpoker

CLI tool and library for testing SMPTE ST2110 SDP files.
Apache License 2.0
38 stars 4 forks source link

fmtp pattern doesn't match ST 2110-20:2022 section 7.1 #33

Open Queueless opened 1 year ago

Queueless commented 1 year ago

The pattern for matching the fmtp attribute expects a semicolon after every parameter entry, and the examples included in this project match that pattern, but the specification contradicts this: Section 7.1 states:

IETF RFC 4566 section “SDP Attributes” specifies the a=fmtp clause including <format specific parameters>. The section shall consist of a sequence of media type parameter entries, separated by the semicolon (“;”) character followed by whitespace. There is no semicolon character after the last item. The a=fmtp clause shall be terminated by a carriage return.

Is this an oversight, intentional, or a versioning issue?

I can make a pull request if this is a simple bug, but since there is specific code to handle a trailing whitespace, I'm assuming that something has changed, and there needs to be a update to handle SDP's that follow this specification.

garethsb commented 1 year ago

Please see #30. This is fixed in the AMWA-TV/sdpoker fork.

FWIW, as you suspected the previous revision of ST 2110-20 required the trailing semicolon where the current one bans it. I campaigned before the revision was published for a spec that didn't break backward compatibility, since any sane implementation is going to have to support both, but I lost.