Ancillary not supported.

Streampunk / sdpoker

CLI tool and library for testing SMPTE ST2110 SDP files.

Apache License 2.0

37 stars 4 forks source link

Closed pkeroulas closed 5 years ago

pkeroulas commented 5 years ago

Hello Richard, Is there a plan to cover ST2110-40? Thanks, PK

sparkpunkd commented 5 years ago

No plan. Open to forks and pull requests.

I don't have a copy of ST2110-40 and we're not working on ST2110 or NMOS at this time unless the activity is sponsored.

pkeroulas commented 5 years ago

Understood. The actual issue is that SDPoker is confused by "m=video" which also applies to ancillary data (https://tools.ietf.org/id/draft-ietf-payload-rtp-ancillary-10.xml#n-sdp-considerations). I assume the rational was that ancillary is embedded in video signal in the SDI world.

The result is false positives because video tests are performed over ancillary description for which "fmtp" and "rtpmap" rules are different.

PR#7 should fix it.

pkeroulas commented 5 years ago

@sparkpunkd, did you have a chance to look at the PR ? It basically fixes the false positive on ancillary.

sparkpunkd commented 5 years ago

Just merged. Thanks for looking into this and providing the fix.