search

Strech / avrora

A convenient Elixir library to work with Avro messages, schemas and Confluent® Schema Registry
https://hexdocs.pm/avrora
MIT License
98 stars 33 forks source link

Logger.warn/1 is deprecated. Use Logger.warning/2 instead #107

Closed trbngr closed 1 year ago

trbngr commented 1 year ago

Updates Logger.warn/1 calls to Logger.warning/2

trbngr commented 1 year ago

It appears that Logger.warning/2 was added in Elixir v1.11 but your build runner is testing really old Elixir versions.

Even the minimal version of Elixir that supports Logger.warning/2 is pretty old. Is it necessary to support such old versions of Elixir?

If you want, or need, to support them, I will have to wrap the logger call in a macro that checks version compatibility at compile time. I know this is a small macro, but it can make the code needlessly complex if you don't need to support < Elixir v1.11

woylie commented 1 year ago

The oldest officially supported Elixir version is 1.11 now: https://hexdocs.pm/elixir/1.15.2/compatibility-and-deprecations.html

Strech commented 1 year ago

👋🏼 Hey folks, thanks for the issue. I think it makes sense to bump the minimum version to the oldest supported.

I'm going to push a bit into this branch and merge it ASAP 👏🏼

Strech commented 1 year ago

Thanks a lot for your contribution, new release was published as 0.27