search

StreetVoice / HysteriaPlayer

Objective-C audio player, sitting on top of AVPlayer
Other
583 stars 99 forks source link

Remove pausePlayerForcibly: #100

Closed saiday closed 8 years ago

saiday commented 8 years ago

It's too hard to use, bad design.

praveenkumar56060 commented 8 years ago

So? Are you going to introduce anything instead this?

saiday commented 8 years ago

Yes, a pause method with explicitly intention.

newbdez33 commented 8 years ago

need a hand?

saiday commented 8 years ago

@newbdez33 sure! it would be great if you could do this

newbdez33 commented 8 years ago

My frist thought:

  1. move pausePlayerForcibly: to Deprecation section and flag it as deprecated.
  2. add pauseReasonForced = true to pause: method

any suggestion?

saiday commented 8 years ago

Have no any other suggestions, I totally agree with you. a useful DEPRECATED_MSG_ATTRIBUTE is what we need.

newbdez33 commented 8 years ago

Sure. I will start a pull request later.