Stremio / stremio-addon-sdk

🧙 A Node.js SDK for creating and publishing Stremio add-ons
https://www.stremio.com/addon-sdk
MIT License
656 stars 175 forks source link

Manifest.config.key conflicts with reserved keyword "key". #263

Open megadrive opened 7 months ago

megadrive commented 7 months ago

Using "key" as an object key can lead to issues as it's a reserved keyword. TypeScript threw this up for me as an error. Rather than "key", another word should be used.

The reference in docs: https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/responses/manifest.md#config-format

jaruba commented 7 months ago

i propose length

megadrive commented 7 months ago

I'm assuming you're joking, but why not id?

jaruba commented 7 months ago

the addon configuration properties do no impact the addon sdk in any way, key is just used as an example, it can be changed to secretKey in the docs / example