search

Stremio / stremio-addon-sdk

🧙 A Node.js SDK for creating and publishing Stremio add-ons
https://www.stremio.com/addon-sdk
MIT License
688 stars 182 forks source link

add: support for multiselect in config form #296

Open hexdecimal16 opened 3 months ago

hexdecimal16 commented 3 months ago

this will add option to use mutli select form field when setting up configuration for manifest.json

jaruba commented 3 months ago

it's funny that i have to review the PR of the guy that is trying to ruin my side business 😂

hexdecimal16 commented 3 months ago

@jaruba are you the developer of RPDB?

jaruba commented 3 months ago

yeah, and incidentally also the dev lead at Stremio and maintainer of the addon sdk 😄

hexdecimal16 commented 2 months ago

Ohh, my aim was to just make the svg manupilation logic open source and configurable. Rating fetching part is very hard to keep consistent. People will pay you just for the rating part ig.

jaruba commented 2 months ago

while i can't do much about it, i can at least share my POV: i invented this concept many years ago in an attempt to expand the ratings possibilities of apps, many have made variations of it since, for specific use cases, great ideas are meant to be spread i guess; imo building a self-hosted solution for this for Stremio users is cool, i can't presume ill intent if the purpose is to offer something for free to people, but then you started hosting on elfhosted, and if elfhosted will end up asking for money for this from users (which is very likely, as elfhosted is a for-profit company), then aren't you just building the same thing all over again so someone else can try to make money from it? which is not cool and not in line with "free alternative" mindset 🤷‍♂️ as i said though, i can't do much about it, just sharing my thoughts on the matter, i hope you can keep it free as it was initially advertised

hexdecimal16 commented 2 months ago

I didn't host it anywhere apart from the ngrok link that I have shared in the repo itself. That is for my personal use and has high downtimes. Someone took the code and hosted it. I have no affliation with them. I asked them to host it just to provide POC to people who don't have access/ don't know how to host for themself.

I have no intentions on monetising it.

hexdecimal16 commented 4 weeks ago

Not merging it? @jaruba

jaruba commented 3 weeks ago

@hexdecimal16 srry about that, i never found time for it and it was a low priority task, my fear with this PR is that it complicates the settings quite a bit, if we choose to move addon settings to the apps (instead of the browser) at some point, then the multiselect option becomes hard to implement in all the different clients