Stremio / stremio-bugs

🐛 Post bug reports in Issues here
64 stars 10 forks source link

Embedded subtitles are smaller than intended, breaking typesetting. (Desktop) #521

Open fedew04 opened 1 year ago

fedew04 commented 1 year ago

Describe the bug Subtitles are showing smaller than they should be, which breaks a lot of complex typesetting. This is provable by comparing the subtitles on Stremio with the same subtitles on MPV (where they show correctly). I'm pretty sure the problem is the subtitle size, since when you change the size up to 160%, it displays closer to how it should look. The Android app displays the typesetting in the intended position. Look at the images for a better understanding of the issue.

To Reproduce Steps to reproduce the behavior:

  1. Play this magnet link on Stremio: https://api.onepace.net/download/magnet.php?hash=b49ba708f178848d3430cbb7899ab0f8caecfdf1
  2. Go to 00:00 and 01:42. You will notice the typesetting is broken.
  3. Open the same video in MPV and go to the same timestamps. The typesetting will show correctly.
  4. Change the subtitle size to 160% in Stremio. It will look closer to how it looks in MPV, but it's still not correct.

Expected behavior The typesetting should work how it is meant to. Check screenshots.

Screenshots

Exhibit A: MPV: image Stremio (at 100% size): image Stremio (at 160% size): image

Exhibit B: (this one is better understood in motion, it's karaoke) MPV: image Stremio (at 100% size): image Stremio (at 160% size): image

Exhibit C: MPV: image Stremio (at 100% size): image Stremio (at 160% size): image


Device information:

Additional context Ideally all subtitles should look correctly in 100% size. Let me know if you need any info about the subtitles.

squiddingme commented 4 months ago

It seems like when the Stremio desktop app (4.4.168) first plays a video, it doesn't apply any subtitle size preference to the embedded subtitles, so embedded subtitles with typesetting display correctly. However, backing out of a video and playing another one (or the same one again) will change the subtitle size, potentially breaking typesetting.

I wonder if 150% is the correct size for these subtitles but can't be selected because the subtitle sizes are increments of 20%?

fedew04 commented 4 months ago

It seems like when the Stremio desktop app (4.4.168) first plays a video, it doesn't apply any subtitle size preference to the embedded subtitles, so embedded subtitles with typesetting display correctly. However, backing out of a video and playing another one (or the same one again) will change the subtitle size, potentially breaking typesetting.

I wonder if 150% is the correct size for these subtitles but can't be selected because the subtitle sizes are increments of 20%?

This might be exactly what's happening. It has to be related to Issue #422 . Thanks for the input.