Stremio / stremio-bugs

🐛 Post bug reports in Issues here
70 stars 10 forks source link

Samsung Tizen 1.3.0 - No watched indicator and no skip to next episode #750

Open chestermw opened 7 months ago

chestermw commented 7 months ago

Describe the bug There is n watch or progress indicator in Samsung Tizen app 1.3.0. Hence, most of the time, we could not remember where we are in the series 😄 There is no "Skip Credits" button as well which you can find on android version.

To Reproduce

  1. Watch any show episode, then finish the episode.
  2. Go back to details of the series and you will see that there was no "Check" marks (same as EP6 in ss). Although it is possible to manually mark episodes as watched (see button in screenshot).

Expected behavior Episodes should be marked as completed with a "Check mark" automatically when you finish an episode (like EP5 in ss).

Screenshots image

TV (please complete the following information):

elpiel commented 7 months ago

Hello @chestermw, Thanks for reporting this issue. In order to track the issue down, could you please check if the series that you are watching is in your Library?

chestermw commented 7 months ago

hello @elpiel,

Huh! That's interesting. i believe i had this in my library, but for some reason it is gone. I have re-added the show to test out and noticed that after playing one episode, it removes itself from the library. Steps to replicate:

  1. Added show to my library.
  2. Played and finished one episode making the app play the next one.
  3. Go back to my library and the show is gone!

Additional info: If you select "Continue playing", it knows where I left and continue playing there, but no indicators as to which episodes have been completed.

elpiel commented 6 months ago

Hello @chestermw ,

Watched indicator

For the watch indicator we have found a possible issue and a fix has been proposed https://github.com/Stremio/stremio-core/pull/675

Do you have any recollection how you are watching an episode?

We have an 70% threshold for marking an item as watched and if you have been seeking more than e.g. ~6.3 minutes (in the case of Modern family with 21 m episodes) or skipped right to the end it will not mark your episode as watched.

Removed from library

  1. I was unable to reproduce this issue on stremio-web (the tizen app is based on it), could you repeat the same steps in https://web.stremio.com/ to compare the result.

Also, there are 2 different buttons (at least on stremio-web) for playing the next episode, one is the pop-up and the other is the player (I guess your remote has a button too)

  1. Could you also revisit the Library and see if the sorting has changed, i.e. if the movie series has shifted places somewhere in the list?

You can easily find your Library separated in 2 LocalStorage keys, we are interested in the library_recent:

image

I'm also taking a look at the tizen code as we speak to try and find a difference that is causing this behaviour

elpiel commented 6 months ago

@chestermw Ok, digging deeper and discussing it with the team, I managed to reproduce the disappearing LibraryItem only once and couldn't repeat it anymore.... I'm trying to reliably reproduce it to see what's causing it. There's nothing apparent in the code so far.

In the tizen app there is currently an issue with the pagination so not all of your Series and movies will show in the Library.

Could you please check the library_recent key through the browser LocalStorage when you visit https://web.stremio.com/ with your profile? If Modern Family is there (and please share the value) after it has disappeared then it might also be part of the pagination bug.

The disappearing can happen if the json has removed: true

chestermw commented 6 months ago

hi @elpiel ,

here's the key value for modern family. you are right. remove is set to true!

"tt1442437": { "_id": "tt1442437", "name": "Modern Family", "type": "series", "poster": "https://images.metahub.space/poster/medium/tt1442437/img", "posterShape": "poster", "removed": true, "temp": true, "_ctime": "2024-03-13T17:55:43.795Z", "_mtime": "2024-04-16T15:13:19.901Z", "state": { "lastWatched": "2024-04-16T15:13:16.190Z", "timeWatched": 2040, "timeOffset": 2040, "overallTimeWatched": 70322088, "timesWatched": 14, "flaggedWatched": 0, "duration": 30080, "video_id": "tt1442437:1:1", "watched": "tt1442437:9:5:197:eJxjYEAHDgcY/yl+kYfyACMsAzQ=", "noNotif": false },

relating to the watch progress: Yes, we watch an episode completely everytime and just wait for it to auto play next episode. Also because there is no "Play Next" button at the end of each show, hence we just wait for it.

elpiel commented 6 months ago

Re: Play next

one of the bug fixes for the button hasn't been included in the latest build so it's possible that this is causing the issue. I'm currently testing this to confirm it.

Re: Watched indicator

The app was using a throttle function and core though it's a seek action for the user. You can see my comment here for explanation, but this is UI issue that will be resolved.

https://github.com/Stremio/stremio-core/pull/675#issuecomment-2079265777

Re: Library Item disappearing

Still no clue how this happens, tried to reproduced it with existing and non-existing in the Library items but so far reproduced it only that one time... I'm still investigating it

chestermw commented 6 months ago

Thank you @elpiel for the support!

elpiel commented 6 months ago

@chestermw we've found the bug for the LibraryItem disappearing. It was caused by a UI bug making the library item disappear, rather than a stremio-core issue.

I cannot tell you when these fixes will land in the app but there are PRs which fix both issues.

While the Player next video should be fixed by updating to latest core-web, which has already been done as well.

chestermw commented 6 months ago

Hey @elpiel

thank you for this update.

I do not really mind the library item missing. what would be great would be the watched indicator and play next

Thanks again!