search

Stremio / stremio-bugs

🐛 Post bug reports in Issues here
59 stars 9 forks source link

Official OpenSubtitles add-on does not show all subs available on the website #787

Closed jan-kleks closed 1 month ago

jan-kleks commented 1 month ago

Describe the bug The official OpenSubtitles add-on does not show all subs available on the website: https://www.opensubtitles.com/

To Reproduce 1) Look for subtitles, e.g. for this movie: https://www.imdb.com/title/tt0416044/ on https://www.opensubtitles.com/ 2) Look for subtitles, e.g. in Polish -- there are 3 pages of available subtitles 3) You cannot see any Polish subtitles in Stremio

Additional context

ahmadesat commented 1 month ago

I am facing same issue as well. It simply doesn't fetch all the subs available.

Other people pointed out that most sub files are "incompatible" with Stremio, so I'm not sure where to go from there. Hoping that Stremio team would find a way to make all the sub files work.

TRtomasz commented 1 month ago

There is no bug, i'v checked few subtitles files for polish language, they all have CD1 in their names suggesting that there are more files for other CDs. Like in older times movies were split on multiple CDs. We filter out subtitles with CD1/CD2 in the name because they usually cover only part of the video. You can always download them manually and drag and drop into stremio if you use desktop app.

jan-kleks commented 1 month ago

@TRtomasz I can see your logic when it comes to the movies split onto multiple CDs. However, I cannot see ANY subtitles in Stremio for the movie I mentioned above... Maybe something else is wrong with the filtering?

Another example of a movie with many Polish subs on OpenSubtitles website, and none showing in Stremio: https://www.imdb.com/title/tt0365748/

TRtomasz commented 1 month ago

Same issue all marked as CD1

jan-kleks commented 1 month ago

@TRtomasz I am sad :( because I really do not want to sound ungrateful (for your awesome work!), or as if I am wasting your time but I think the issue is really there.

I have found out there was a little discussion regarding this very problem on reddit: https://old.reddit.com/r/Stremio/comments/1ct03fd/official_opensubtitles_addon_does_not_show_all/

And this discussion brought might attention to these exact subtitles. And as you can see they are in the srt format, and no CD1 in the file name. As this is a pretty popular movie, it is really weird that I can't see these (seemingly meeting your criteria), or for that matter any other Polish subtitles when watching it.

Another movie, and another example, of the unavailable subtitles seemingly meeting your criteria.

I can also see, based on the info from that reddit thread, that you also limit the subtitles based on their number:

We filter out subtitles that have CD1 or CD2 in their name also filter out subtitles that are not in srt format and we limit max subtitles to 500 and max subtitles per language to 25.

Maybe by mistake you filter the good srt ones as well...

Tested both on Linux desktop and Android TV including various versions of the same movies.

TRtomasz commented 1 month ago

There is no bug or issue this is different api not used by stremio

jan-kleks commented 1 month ago

@TRtomasz These exact subtitles linked above are available on the older OpenSubtitles website as well. Does the OpenSubtitles api not give you access to every srt file on the old/new website for some reason?

I do not quite understand where is the difference between these non-working srt subtitles and the srt ones that work in Stremio's add-on...

jan-kleks commented 1 month ago

@TRtomasz There is also this unofficial OpenSubtitles "UFO" add-on, and it seems to download lots of subtitles for all the movies I mentioned in this thread, so there is definitely room of improvement when it comes to the official add-on.

Keep up the great work!