Stremio / stremio-bugs

🐛 Post bug reports in Issues here
65 stars 10 forks source link

TV channels cannot be filtered by genre on Android TV and Web client #885

Closed DryKillLogic closed 1 month ago

DryKillLogic commented 1 month ago

Describe the bug On discovery, TV channels cannot be filtered by genre on Android TV and Web client. In other platforms work as expected. I'm unsure whether this is a bug or hasn't been implemented yet. Thanks!

To Reproduce Steps to reproduce the behavior:

  1. Go to the Discovery page on Android TV or the Web client
  2. Select TV channels
  3. Try to filter by genre
  4. No genres are shown in the dropdown

Expected behavior The list of genres should be displayed

Additional This might be the case for other platforms which I don't have access to.

TRtomasz commented 1 month ago

Which addon are you using?

DryKillLogic commented 1 month ago

@TRtomasz https://stremio-addons.netlify.app/usa-tv

TRtomasz commented 1 month ago

@DryKillLogic this is not stremio issue, this addon does not adhere to the new stremio addon sdk thats why it is not possible to select genres in new apps image

dexter21767-dev commented 1 month ago

@DryKillLogic a follow-up on what @TRtomasz said,

here's what the fixed version should look like

{
  "id": "community.usatv",
  "version": "1.1.0",
  "catalogs": [
    {
      "name": "USA TV",
      "type": "tv",
      "id": "all",
      "extra": [
        {
          "name": "genre",
          "isRequired": false,
          "options": [
            "Local",
            "News",
            "Sports",
            "Entertainment",
            "Lifestyle",
            "Kids",
            "Spanish",
            "Documentaries"
          ]
        }
      ]
    }
  ],
  "resources": [
    "catalog",
    "stream",
    "meta"
  ],
  "types": [
    "tv"
  ],
  "name": "USA TV",
  "description": "USA TV provides access to channels across various categories including local channels, news, sports, entertainment, lifestyle, kids' shows, Spanish-language programming, documentaries, and much more.",
  "logo": "https://848b3516657c-usatv.baby-beamup.club/public/logo.png",
  "background": "https://848b3516657c-usatv.baby-beamup.club/public/background.jpg"
}

also i would highly suggest using the idPrefixes property cuz as it's now, a user that has the addon installed, will send a request to your addon whenever he's trying to watch anything with the type "tv", which can overload your addon with unnecessary requests.

DryKillLogic commented 1 month ago

@dexter21767-dev @TRtomasz Thanks guys for the help. I will implement those changes.