search

Stremio / stremio-core

⚛️ The Stremio Core: types, addon system, UI models, core logic
MIT License
948 stars 68 forks source link

fix(player): always update LibraryItem time_offset on NextVideo #676

Closed elpiel closed 3 months ago

elpiel commented 5 months ago

Steps to reproduce bug:

https://localhost:8080/#/detail/series/tt13210838/tt13210838%3A1%3A2

  1. Choose The gentleman episode 2 (make sure streams key doesn't contain it, i.e. you have not watched any stream from there)
  2. Start playing a stream that's part of a bingewatch group (to see the next video/episode button in player)
  3. Jump to time > 50:01, e.g. 55 minutes
  4. Click next video episode (from the Seekbar but probably the Pop-up will work as well)
  5. Episode 3 starts playing ~ the last second of the video, time_offset hasn't been updated so it tries to load the next episode at the 55 minutes mark (from previous episode)
tymmesyde commented 5 months ago

What is it fixing exactly so i can reproduce and test ?

elpiel commented 4 months ago

check out the last played episode which jumps straight to the end once you've clicked the Next video button in the player https://github.com/Stremio/stremio-core/assets/8925621/b2e87b90-cc20-4908-878f-8b42389e111a