search

Stremio / stremio-shell

🐚 Qt5-based shell for Stremio; compile this to run the desktop app
GNU General Public License v3.0
522 stars 114 forks source link

Build for Windows failed #381

Open SpeedyR10 opened 7 months ago

SpeedyR10 commented 7 months ago

Hi! My goal is to make Stremio fullscreen when it is launched, it would only be a PR if you deem it useful. I first started by following every step in the documentation but when I reached

cmake -G"NMake Makefiles" -DCMAKE_BUILD_TYPE=Release ..

it failed with the message "CMake Error: The source directory "C:/Users/X/source/repos" does not appear to contain CMakeLists.txt."

I did this cmake -G"NMake Makefiles" -DCMAKE_BUILD_TYPE=Release instead and it appeared to work but after the next step I have no folder called "release".

Also I'm also missing "msvcr120.dll" from the "windows" folder, not sure if it's needed.

Since there was no release folder I ended up copying a "stremio.exe" from the root folder to the dist-win folder but I'm not sure if that's right.

I also don't have that much knowledge in how to debug this, I come from a C# background and this is a bit new, if you have some pointers would really appreciate it. Also if there's already a solution for making Stremio fullscreen when it's launched, please let me know.

SpeedyR10 commented 7 months ago

Hi again,

An update, even tho I couldn't debug I found a way to get it to be fullscreen, passing in an argument stremio.exe --fullscreen, just like in the code below: image I'm still trying to work out why it freezes after I try to minimize it. I think it might have to do with the root.height and root.width defined before. Maybe this is not the place to do this, I just wanted to test to see it working. The build is not perfect and I have an issue regarding OpenGL and then this: image From what I see it's trying to get "stremio-runtime.exe" and I don't have it in the current application folder.

UPDATE I solved the previous issues by using the "stremio-runtime.exe" that I had installed. I'm assuming this is a binary from another repository (maybe service) and if so how do you combine everything into the final installer that the client uses?

I still have a problem with QT Creator, I have no errors while buiding (Open SSL dependency is in the proper directory) but when I try to run or debug as you can see in the image above it crashes. It also displays this in the "General Messages" image The more I'm starting to understand it, the more I want to help. I would really love to get this working and start contributing to other issues you may have in the future.