search

Stremio / stremio-shell

🐚 Qt5-based shell for Stremio; compile this to run the desktop app
GNU General Public License v3.0
522 stars 114 forks source link

Silent installer + command line options #398

Closed hyperion4 closed 2 months ago

hyperion4 commented 2 months ago

/notorrentassoc - does not associate Stremio with .torrent files /nodesktopicon - does not create Desktop shortcut for Stremio

They don't work. The silent installer even with them associates torrent files and creates the icon on desktop. I think I am launching them properly. Please let me know if I don't.

"Stremio.exe" /S /notorrentassoc /nodesktopicon

I think the problem is NSIS actually. It always had issues with silent commandline options. I don't understand why programs keep using NSIS for their installers. Fortunately the installer of the Stremio service is using Inno Setup. Inno Setup is well maintained and with a modern interface.

Please let me know if I am wrong and not lauching them properly.

TRtomasz commented 2 months ago

Here is our installator file, feel free to fix issues if you are able to find them https://github.com/Stremio/stremio-shell/blob/master/windows/installer/windows-installer.nsi

hyperion4 commented 2 months ago

Here is our installator file, feel free to fix issues if you are able to find them https://github.com/Stremio/stremio-shell/blob/master/windows/installer/windows-installer.nsi

If I make a new installer with Inno Setup like the installer the Stremio service has will it be accepted? I am not messing with NSIS and I will make an Inno Setup installer for my personal usage anyway. My installer won't even mess with associations during installation and uninstallation, it will register Stremio as a windows application that can be associated with torrent and magnet links. User will choose from windows settings if he wants to associate torrent and magnet with Stremio. There is no reason for an installer to mess user's associations and most importantly guess itself the restored torrent association itself from stremio_backup registry value it is used now. It's not a reliable way and today since Microsoft finally did something about it and introduced application registration in windows 10, there is a more proper way to do all these. https://learn.microsoft.com/en-us/windows/win32/shell/default-programs Thank you for your reply.

jaruba commented 2 months ago

@hyperion4 we have been sending reports to tens of Antivirus companies for months regarding false-positives for Inno Setup because we use it in Stremio Service, progress is slow and in the meanwhile even more Antivirus software added it to lists

we have never had this issue with the Desktop app and NSIS, so we will continue to use NSIS for the Desktop app

while I understand ur point there doesn't seem to be much interest for Stremio users regarding the protocol association method, as it has been done like this for many many years, so I do not think that this is a valid reason to ditch NSIS for Inno at this point

hyperion4 commented 2 months ago

@hyperion4 we have been sending reports to tens of Antivirus companies for months regarding false-positives for Inno Setup because we use it in Stremio Service, progress is slow and in the meanwhile even more Antivirus software added it to lists

we have never had this issue with the Desktop app and NSIS, so we will continue to use NSIS for the Desktop app

while I understand ur point there doesn't seem to be much interest for Stremio users regarding the protocol association method, as it has been done like this for many many years, so I do not think that this is a valid reason to ditch NSIS for Inno at this point

Thank you for your reply. I 've made a "quick to code" inno installer for personal usage "on top" of the nsis installer that installs stremio silently and reverts the torrent association, keeps the current association if it exists and removes the desktop icon. If you are interested to try it, this is a link of it. https://pixeldrain.com/u/oNSPYvTm If you guys ever decide to use Inno I will for sure help on it, inno supports pascal coding too so it is easy to update a nsis installer to inno. Thank you again for your reply.