search

Stremio / stremio-web

Stremio - Freedom to Stream
GNU General Public License v2.0
1.09k stars 233 forks source link

Trailer Preview #533

Open Mkdantas opened 9 months ago

Mkdantas commented 9 months ago

There isn't an option for trailer preview like most streaming services when you are hovering through their library. I tried implementing it, however, this is my first issue ever, please provide me with feedback and guide me on changes i should make if possible.

Trailer preview)

I used the ytId to embed a youtube video, however, if there is a way to serve the video id like how it is provided in metaDetails i could use stremio's player instead of youtube to show a preview of the trailer.

this is my fork with the above updates committed https://github.com/Mkdantas/stremio-web

Iheuzio commented 9 months ago

An alternative could be to use the same trailer url and serve that video.

Mkdantas commented 9 months ago

An alternative could be to use the same trailer url and serve that video.

Yeah, do you know how I can get that url to be in metaItem props? The trailer url present in metaDetail is not present in metaItem

Iheuzio commented 9 months ago

An alternative could be to use the same trailer url and serve that video.

Yeah, do you know how I can get that url to be in metaItem props? The trailer url present in metaDetail is not present in metaItem

Nevermind, I see what you're trying to achieve. Its a pretty cool implementation, however for actual general use it would be best to leave the embeded players in their own window, thus the trailer pane is fine as is.

On mobile this wouldn't work, nor android tvs. It would create a navigation problem for the users.