search

Strider-CD / core

Strider Core
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

Does core need providers? #11

Open knownasilya opened 9 years ago

knownasilya commented 9 years ago

I'm just wondering if Core really needs providers e.g. Github, Bitbucket, etc, since the work will be done by the drones, core only handles the webhooks to trigger drones.

What would be the benefit of providers on core?

microadam commented 9 years ago

"core only handles the webhooks to trigger drones"

Without providers, how can the webhooks be setup and configured? :)

On 22 Aug 2015, at 22:39, Ilya Radchenko notifications@github.com wrote:

I'm just wondering if Core really needs providers e.g. Github, Bitbucket, etc, since the work will be done by the drones, core only handles the webhooks to trigger drones.

What would be the benefit of providers on core?

— Reply to this email directly or view it on GitHub.

knownasilya commented 9 years ago

Ok what I meant by "no providers" is no provider specific APIs apart from webhooks and auth. Should have been more clear.

Really we need to be able to trigger by provider, and convert the providers trigger data to something structured/generic. Setting up webhooks doesn't even have to be automatic right away, since even now we have issues with it, and manual setup isn't so bad (only once per project).

There doesn't need to be any cloning or getting a file (strider.json), or handling ssh keys..

phiros commented 9 years ago

I agree that we don't really need providers in the classical sense. If someone needs a functionality where you look into the repo in order determine what to do with the job before sending it to a drone we can implement this a plugin.

BTW: I plan to implement such a plugin very soon after having the basic functionality of core + drone implemented. The use case would be: