search

Strider-CD / core

Strider Core
BSD 3-Clause "New" or "Revised" License
10 stars 4 forks source link

refactor + job management #12

Closed phiros closed 9 years ago

phiros commented 9 years ago

My refactor of core. I swapped out seneca with EventEmitter3 (don't really care if we use EventEmitter2 or 3). For persistence I went with lokijs which I encapsulated in a class (using ES6 classes). We can change this latter on.

BTW: iojs seems to dislike Primus. On ubuntu 15.04 with the most recent version of iojs (installed with nvm) I got Segmentation faults... (could also be the combination Primus + traceur-runner + iojs). However, npm start and npm test run flawlessly in node v0.12.7.

knownasilya commented 9 years ago

Why use traceur with iojs? IOjs has ES6 features without the need for a transpiler (I'd go with babel anyways if it was needed), which explains why you were having issues.

phiros commented 9 years ago

hmm not sure that traceur is the problem here:

$ nvm use iojs
$ node --version                                                                                                             
v3.1.0
$ node index.js server                                                                                                     
[1]    15112 segmentation fault (core dumped)  node index.js server

Also support for ES6 features is still spotty in iojs and sometimes even a little bit buggy (see: http://kangax.github.io/compat-table/es6/)

knownasilya commented 9 years ago

Why node index.js server and not just node index.js?

knownasilya commented 9 years ago

Also support for ES6 features is still spotty in iojs and sometimes even a little bit buggy

Then node + babel would probably be best.

phiros commented 9 years ago

node index.js server This is just to distinguish between running index.js as a server and including the code of index for the tests. The check you used doesn't work if you run index.js trough traceur-runner or something other than node.

Regarding ES6: I just went with traceur because it just worked on my machine. For some reason I couldn't get babel to work properly... If you want you can switch the code over to babel (I guess you only need to change package.json?; I've never used babel before...).