search

Strider-CD / heroku-buildpack-nodejs

MIT License
0 stars 2 forks source link

Obsolete? #1

Open jaredly opened 11 years ago

jaredly commented 11 years ago

It looks like this was created before heroku supported nodejs out of the box. Should this still hang around?

niallo commented 11 years ago

Not quite sure. The intention was to add the node headers, so that native modules could build on Heroku.

Will this work without it?

See my commits here:

https://github.com/Strider-CD/heroku-buildpack-nodejs/commits/master

jaredly commented 11 years ago

Hmm. I've certainly had native modules building in Strider on Heroku. bcrypt, for example, is required by strider. And it builds just fine.

niallo commented 11 years ago

No I mean for node projects that are under ci - not quite sure if that's what you mean.

Sent from my iPhone

On Jul 18, 2013, at 10:29 PM, Jared Forsyth notifications@github.com wrote:

Hmm. I've certainly had native modules building in Strider on Heroku. bcrypt, for example, is required by strider. And it builds just fine.

— Reply to this email directly or view it on GitHub.

jaredly commented 11 years ago

right; I have strider building under CI - so I think it works just fine.

niallo commented 11 years ago

Ok in that case it isn't needed anymore

Sent from my iPhone

On Jul 19, 2013, at 4:29 AM, Jared Forsyth notifications@github.com wrote:

right; I have strider building under CI - so I think it works just fine.

— Reply to this email directly or view it on GitHub.