search

Strider-CD / strider-custom

Support for custom prepare, test and deploy phases in Strider
9 stars 7 forks source link

strider-custom doesn't override default actions #2

Closed jaredly closed 11 years ago

jaredly commented 11 years ago

I expected it to. Does that make sense? I mean, if I have a nodejs and I want it to do something other than npm test (not just in addition to) how would I do that?

I like travisci's paradigm of replacement.

niallo commented 11 years ago

Here are the docs for how build hooks work:

https://github.com/Strider-CD/strider-extension-loader#build-hooks

For node.js, the simple worker has a single conditional build hook by default. Because real-world projects can have quite a number of build hooks for each phase added by numerous plugins, it becomes complicated to do overrides safely.

In practice, we haven't found this to be necessary.

When would running npm test be problematic? If really necessary, you could no-op this in your project.

jaredly commented 11 years ago

hmmm I guess this makes sense.

On Sat, Jul 13, 2013 at 10:38 AM, niallo notifications@github.com wrote:

Here are the docs for how build hooks work:

https://github.com/Strider-CD/strider-extension-loader#build-hooks

For node.js, the simple worker has a single conditional build hook by default. Because real-world projects can have quite a number of build hooks for each phase added by numerous plugins, it becomes complicated to do overrides safely.

In practice, we haven't found this to be necessary.

When would running npm test be problematic? If really necessary, you could no-op this in your project.

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider-custom/issues/2#issuecomment-20922534 .