search

Strider-CD / strider-custom

Support for custom prepare, test and deploy phases in Strider
9 stars 7 forks source link

The shell editor view doesn't initialize correctly #28

Closed vqoph closed 8 years ago

vqoph commented 8 years ago

capture d ecran 2016-01-28 a 22 40 32

has you can see in the screenshot, the editor doesn't initialize correctly, does anyone have the same issue ?

to initialize this view i need to resize my browser window

knownasilya commented 8 years ago

I see the same issue. It fixes if you open devtools. I've yet to find the cause.

Would love some eyes on it.

vqoph commented 8 years ago

I can try to help but do you have any recommandation to contribute ?

knownasilya commented 8 years ago

Well the codeblocks use https://github.com/angular-ui/ui-codemirror so maybe some dependency issues? Might be worthwhile cross posting there and see if they have any ideas.

The component is initialized here: https://github.com/Strider-CD/strider-custom/blob/master/config/config.html#L36

See strider repo for the actual dependency. Feel free to submit PRs and we can work on it together.

vqoph commented 8 years ago

I've looked at angular-ui/ui-codemirror issues and the angular-ui/ui-codemirror#111 seems to be the same problem as our, i'll try their workaround

vqoph commented 8 years ago

How do the project manage front end dependencies ? (it's the first time i contribute to a strider-cd plugin project)

knownasilya commented 8 years ago

The frontend deps for this plugin are actually in strider itself (I think this is one of the older plugins).

P.S. maybe we can set ui-refresh to something better, like the current date..

knownasilya commented 8 years ago

https://github.com/Strider-CD/strider/tree/master/vendor/CodeMirror

vqoph commented 8 years ago

in strider project codemirror is set to 3.18.0 and latest is 5.11.1 may be an update of the library can solve our problem

knownasilya commented 8 years ago

No, we would have to update angular as well, and it's a big project. But i think I know why it's not working :+1: Will try to fix in the next day or two.

vqoph commented 8 years ago

ok i understand , i tryed to set ui-refresh to a time based value but i haven't found the right controller

knownasilya commented 8 years ago

The issue is that the scope changes, so it breaks the setup.. trying to figure out the scope issue..

knownasilya commented 8 years ago

Should be fixed in master branch of Strider repo.

vqoph commented 8 years ago

Well it's working for me ! ;) thx a lot for your time