deploy command doesn't run if heroku's not setup

[jaredly]

I think we need to change some logic in strider to make things less heroku dependant.

Or should strider-custom set deploy_config on the repo?

[niallo]

is this still happening after the worker rewrite? it's totally wrong to do this, of course.

[jaredly]

oh yeah it still is. We bypass deploy if there's no "deploytarget". But we're taking heroku and making it a separate plugin, so that will be fixed.

[niallo]

ok, but shouldn't it be a quick fix to always run deploy hooks (not talking about heroku deploy) without heroku config?

[jaredly]

But we don't allow a TEST_AND_DEPLOY run to happen if there's no deploy_target set in the DB. I think we need some way for plugins to broadcast that they can deploy this project

On Thu, Aug 15, 2013 at 2:56 PM, niallo notifications@github.com wrote:

ok, but shouldn't it be a quick fix to always run deploy hooks (not talking about heroku deploy) without heroku config?

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider-custom/issues/5#issuecomment-22729770 .

[sveisvei]

+1, my use of strider does internal deploy locally on same machine.

[jaredly]

fixed by Strider-CD/strider@12c57fc095c88c08fc4b7313c668a67024fb8d1a

[niallo]

awesome @jaredly !