search

Strider-CD / strider-custom

Support for custom prepare, test and deploy phases in Strider
9 stars 7 forks source link

Save on the custom page doesn't seem to work, and the custom scripts don't trigger #7

Closed d3ming closed 10 years ago

d3ming commented 10 years ago

Most of the time when I hit save on the strider-custom config page,nothing happens and the script isn't saved.

However, even when I tried using a strider-custom.json file to the root of my project, it still didn't override the existing behavior which runs 'npm test'. Is there something I'm missing here, is strider-custom meant to override the existing behaviors?

niallo commented 10 years ago

1.3.5 or HEAD ?

d3ming commented 10 years ago

I'm using a fork from 1.4.0pre (https://github.com/vasili-zolotov/strider) but there shouldn't be many changes around the strider-custom functionality

On Fri, Oct 4, 2013 at 4:22 PM, niallo notifications@github.com wrote:

1.3.5 or HEAD ?

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider-custom/issues/7#issuecomment-25736651 .

niallo commented 10 years ago

does it work in 1.3.5? 1.4.0pre was known to have issues. Hence it was named "pre".

d3ming commented 10 years ago

Ah yes, 1.3.5 works so I guess this is a bug in the pre version. Thank!

On Fri, Oct 4, 2013 at 4:40 PM, niallo notifications@github.com wrote:

does it work in 1.3.5? 1.4.0pre was known to have issues.

— Reply to this email directly or view it on GitHubhttps://github.com/Strider-CD/strider-custom/issues/7#issuecomment-25737170 .

niallo commented 10 years ago

Great.