search

Strider-CD / strider-docker-build

Build (and push) Docker images in Strider
16 stars 7 forks source link

Stream context.dataDir to Docker at build-time #11

Closed logankoester closed 9 years ago

logankoester commented 9 years ago

Creating an archive on disk for strider-docker-build during the Prepare phase doesn't work for images that want to include build output or other files generated by Strider in an earlier phase.

This change replaces git archive with the tar-fs module to stream project files directly into Docker when building the image instead.

This also resolves the phase conflict that occurs when attempting to build a Docker image during Prepare, and there are no more archive files soaking up /tmp space.

See #10 (Why work out of archive path?) if you are interested in the specific use case that motivated this.

Note that this branch is based off #5 (Push after build) when merging.

knownasilya commented 9 years ago

@logankoester could you rebase your PR against master? Thanks!

logankoester commented 9 years ago

@knownasilya Sure, I'll take a look.

logankoester commented 9 years ago

@knownasilya Done!

logankoester commented 9 years ago

Hey @knownasilya, any particular issue still blocking this change from being merged?

knownasilya commented 9 years ago

Nothing! I missed that you rebased it.

logankoester commented 9 years ago

Awesome, thank you!

knownasilya commented 9 years ago

Deployed