search

Strider-CD / strider-docker-build

Build (and push) Docker images in Strider
16 stars 7 forks source link

Should fix the parse error going to event-stream. #13

Closed davemackintosh closed 9 years ago

davemackintosh commented 9 years ago

This should fix the parse issue from the container going to event-stream

The issue is event-stream only accepts JSON and the stream is piping plain strings, just try to parse as JSON and if it fails, make it JSON.

I thought this was an issue with event-stream and it is not so I've closed my PR to them.

@keyvanfatehi @knownasilya

davemackintosh commented 9 years ago

This is related to an issue in #5

davemackintosh commented 9 years ago

Do not merge this. Dun goofed.

knownasilya commented 9 years ago

How come you closed this PR?

davemackintosh commented 9 years ago

I was testing it and ran out of time before it was fully tested so closed to be sure no broken code got merged in. If it works then reopen?

knownasilya commented 9 years ago

Seems like the push after build PR fixed the parse issue.

davemackintosh commented 9 years ago

Great job!