search

Strider-CD / strider-docker-build

Build (and push) Docker images in Strider
16 stars 7 forks source link

Image push is not working #17

Closed chriz2600 closed 8 years ago

chriz2600 commented 8 years ago

When you use "Push after successful build?" the build fails, because image.push is not invoked correctly in lib/push.js. The image.push function from dockerode has the following signature: Image.prototype.push = function(opts, callback, auth) {...} In lib/push.js image.push(function() {...}) is used, which leads to an error, when Image.push tries to invoke the callback. I added an empty object as first parameter to image.push, which works for me now.

knownasilya commented 8 years ago

Interesting, seems like that API changed (author doesn't follow semver). Think you could submit a PR?

chriz2600 commented 8 years ago

API (for Image.push) did not change since initial release v0.2.5.

knownasilya commented 8 years ago

Weird. It worked before..

knownasilya commented 8 years ago

Seems like https://github.com/apocas/dockerode/commit/11d196a5e80f0e5bcec45b82c274db9946b33618 is the culprit. But yes, it looks to be used incorrectly.

knownasilya commented 8 years ago

@chriz2600 can you give master a try?

chriz2600 commented 8 years ago

This is exactly the change i made locally. Works! Thank you!

knownasilya commented 8 years ago

Ok, I'll release a new version.