search

Strider-CD / strider-docker-build

Build (and push) Docker images in Strider
16 stars 7 forks source link

Add ability to run build on test #4

Closed davemackintosh closed 9 years ago

davemackintosh commented 9 years ago

I've added the ability to run the build on test as well as deploy and tidied a few bits up that I came across.

Open for discussion.

knownasilya commented 9 years ago

What's the benefit of building twice, or am I miss-understanding?

davemackintosh commented 9 years ago

I didn't want to remove the current behaviour but add new behaviour to build on test.

knownasilya commented 9 years ago

Could you have a either a dropdown that selects when to build (or radio buttons) instead of a checkbox. Because I don't think it makes sense to build twice, so a choice would be more appropriate, defaulting to current behavior.

davemackintosh commented 9 years ago

No probs, that makes sense to me. Will do that now.

davemackintosh commented 9 years ago

There we go, it is now a dropdown. I forgot how finicky Angular is with the select tag.

knownasilya commented 9 years ago

Other then my last comment everything looks good. Once you've finished tinkering, if you could squash your commits, that would be appreciated.

davemackintosh commented 9 years ago

I totally did not know you could squash commits. You've blown my mind with that ha, so many time I've wanted to do that and not bothered Googling..

knownasilya commented 9 years ago

:neckbeard: yeah fun stuff.