search

Strider-CD / strider-docker-build

Build (and push) Docker images in Strider
16 stars 7 forks source link

Setting phase to `prepare` causes the tar to not happen. #9

Closed davemackintosh closed 9 years ago

davemackintosh commented 9 years ago

Setting the phase to build image on to prepare causes the tar to not happen which breaks everything. Introduced in last PR #8.

knownasilya commented 9 years ago

Yeah, not sure how to handle this, maybe prepend the command.

davemackintosh commented 9 years ago

I was thinking the same, maybe we need to think about a hook system rather than a hard coded set of values or the ability to have arrays of actions to complete per step.

knownasilya commented 9 years ago

Maybe we need a pre-[phase], post-[phase] events, really all of the phases should be events.

davemackintosh commented 9 years ago

It would be minimal work to set up a loop around those keys? Would need to check their type first so to remain backwards compatible but doesn't seem like a lot of work to me.

knownasilya commented 9 years ago

Actually I think they already are events, so yeah, would be pretty trivial.

davemackintosh commented 9 years ago

Do you want to do that or should I fork and do that shortly?

knownasilya commented 9 years ago

@davemackintosh if you have time, a PR would be great, I'm crunching some client work.

davemackintosh commented 9 years ago

No worries, I am as well but I'll get to this once I'm done :)

davemackintosh commented 9 years ago

I will get round to this today or tomorrow, lots of work to do with deadlines!

logankoester commented 9 years ago

I do need to rebase my branch and fix conflicts, but note that if #11 moves forward then this issue will be resolved as a side-effect.

knownasilya commented 9 years ago

Closing in favor of #11