search

Strider-CD / strider-docker-runner

Strider runner that uses Docker
34 stars 19 forks source link

parallel builds #19

Closed jfromaniello closed 7 years ago

jfromaniello commented 10 years ago

can this runner be used to achieve parallel builds?

jaredly commented 10 years ago

very probably. there might be some tweaking necessary, but it shouldn't be hard.

On 9/4/14, José F. Romaniello notifications@github.com wrote:

can this runner be used to achieve parallel builds?

Reply to this email directly or view it on GitHub: https://github.com/Strider-CD/strider-docker-runner/issues/19

kfatehi commented 10 years ago

@jfromaniello have you tried it? it might just work -- let us know either way

jfromaniello commented 10 years ago

Yes, I tried running two projects configured with this runner, but the second one is queued and doesn't start until the first one has ended.

Do I need to change some config?

jaredly commented 10 years ago

there ought to be some config, yes :) right now the concurrent limit of 1 is hard-coded here. If you want to manually change that to see if it works, that would be interesting to see. And then we can plumb it through the normal config channels.

jfromaniello commented 10 years ago

amazing!!! Seems is working :)

jaredly commented 10 years ago

Sweeet El sep 5, 2014 1:52 PM, "José F. Romaniello" notifications@github.com escribió:

amazing!!! Seems is working :)

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-docker-runner/issues/19#issuecomment-54673054 .

niallo commented 10 years ago

Fantastic to hear! Nice work on this @keyvan and @jaredly.

On Fri, Sep 5, 2014 at 12:52 PM, José F. Romaniello < notifications@github.com> wrote:

amazing!!! Seems is working :)

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-docker-runner/issues/19#issuecomment-54673054 .

Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me T: @niallohiggins

jfromaniello commented 10 years ago

It will be nice to have a configuration setting in the ui to change the max number of parallel runs.

Also, I usually don't want the same project to be running two builds on parallel, it makes things confusing. I'd like parallel builds just for different projects

kfatehi commented 9 years ago

yeah good idea. i'd like to see that too, but personally I'm good right now with non-parallel builds. maybe someone with the need will add it in future.

nomean42 commented 8 years ago

Looks like this is not still solved? ((

thedewpoint commented 7 years ago

@nomean42 not sure if you solved this but looks like you can set an environment variable to override the concurrent build settings: https://github.com/Strider-CD/strider-simple-runner/blob/master/lib/index.js#L62
concurrentJobs: parseInt(process.env.CONCURRENT_JOBS || '1', 10) || 1,

knownasilya commented 7 years ago

Yes this also applies to the simple-runner, and is documented in the main Strider repo.