Strider-CD / strider-docker-runner

Strider runner that uses Docker
34 stars 19 forks source link

remove freeport, use docker to assign #2

Closed kfatehi closed 10 years ago

kfatehi commented 10 years ago

there are too many issues with trying to use SSH and freeing a port, and making sure firewalls are open and all that -- i think it's better to do something along these lines:

docker run --rm -a stdin -a stdout -a stderr -i --workdir /data strider/strider-docker-slave bash

basically use the stream at that point to communicate with the container, piping this all back to the strider UI, and the --rm removes the container for us after the session is over too, taking care of #3 as well

kfatehi commented 10 years ago

dockerode makes this real easy, and demuxes the stream for us too -- i'll do this today.

jaredly commented 10 years ago

That's what I tried first, but you don't get the command's exitcode, which is important to strider

jaredly commented 10 years ago

also, I think we should keep the container around if the build fails, so you can inspect it.

jaredly commented 10 years ago

new impl doesn't use an ssh server