search

Strider-CD / strider-docker-runner

Strider runner that uses Docker
34 stars 19 forks source link

Bug when the image's name contains a colon #44

Closed xgalen closed 6 years ago

xgalen commented 6 years ago

Because this line: https://github.com/Strider-CD/strider-docker-runner/blob/8857bf4cdf369ae9616104b6c0206a56e4fbec66/lib/create-container.js#L12

If the name is something like aaaaa:bbbb:latest it does not work. It happened to me.

I don't know if it's better to fix the code, put something in the docs or just don't nothing. Now I know the problem I know how to avoid it (changing the name).

knownasilya commented 6 years ago

Probably fix the code, and only use the last segment, but rejoin the rest.

xgalen commented 6 years ago

Solved with PR #46

knownasilya commented 6 years ago

Tip: In PRs you can say 'fixes #issuenumber' or resolves, etc and it will automatically close the issue when the PR is merged.