search

Strider-CD / strider-docker-runner

Strider runner that uses Docker
34 stars 19 forks source link

Publish to npm #5

Closed knownasilya closed 10 years ago

knownasilya commented 10 years ago

Title says it all :+1:

niallo commented 10 years ago

Thanks for the gentle prodding :)

On Friday, August 8, 2014, Ilya Radchenko notifications@github.com wrote:

Assigned #5 https://github.com/Strider-CD/strider-docker-runner/issues/5 to @niallo https://github.com/niallo.

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-docker-runner/issues/5#event-151003665 .

Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me T: @niallohiggins

jaredly commented 10 years ago

let's wait for a sec until this has settled though

kfatehi commented 10 years ago

lol it's not ready --

kfatehi commented 10 years ago

ill push what i have and paste here, im done for the night -- didnt achieve success

knownasilya commented 10 years ago

Still worth publishing a pre-release.

kfatehi commented 10 years ago

there you go, im out for at least 10 hours... maybe ya'll can fix it lol

jaredly commented 10 years ago

ok :) I'll take a crack

jaredly commented 10 years ago

@keyvanfatehi so the issue is that a container can only run one single command. You can't reattach and run more commands. So there are 2 options:

  1. save the container as a new image after each command
  2. have the SpawnJSON be long-running, and be able to run all the commands we want.

I'm pursuing 2.

jaredly commented 10 years ago

we're in business! published, working (without need for ssh ports), and awesome

niallo commented 10 years ago

Awesome!

On Saturday, August 9, 2014, Jared Forsyth notifications@github.com wrote:

Closed #5 https://github.com/Strider-CD/strider-docker-runner/issues/5.

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-docker-runner/issues/5#event-151024780 .

Niall O'Higgins W: http://niallohiggins.com E: n@niallo.me T: @niallohiggins