search

Strider-CD / strider-git

Basic git provider
12 stars 16 forks source link

webapp.js/getFile() should be stubbed/implemented #21

Open Mixaill opened 9 years ago

Mixaill commented 9 years ago

Due to https://github.com/Strider-CD/strider/commit/e04e8cbbdeef13099578f61c93b627d3548b48d9 changes current getFile() implementation causes build failure with 

error: job.prepare - error opening/processing project's `strider.json` file:  [Error: not implemented]
nexflo commented 9 years ago

Get the same here.

knownasilya commented 9 years ago

Will look into it

knownasilya commented 9 years ago

The error shouldn't stop the build, since it's more of a warning. This hasn't changed the implementation since strider-git has never supported the strider.json file.

knownasilya commented 9 years ago

Although, I'll still look into adding that support.

andrioid commented 9 years ago

After upgrading Strider none of our projects build anymore... The log only reveals "error: job.prepare - error opening/processing project's strider.json file: [Error: not implemented]"

knownasilya commented 9 years ago

I've just published Strider v1.7.4, which should fix the problem. The message will still be printed, since the method isn't implemented, but the build will work as previously.