search

Strider-CD / strider-git

Basic git provider
12 stars 16 forks source link

Strider was crashed when add a git repo without authentication info #33

Open tunglam14 opened 8 years ago

tunglam14 commented 8 years ago

When i create new project manually with no authentication info (i.e: Github public repo: https://github.com/tunglam14/ruby-kong.git), error caused:

 /root/strider/node_modules/strider-git/lib/index.js:137
  if (config.auth.type === 'ssh') {
                 ^                                       
TypeError: Cannot read property 'type' of undefined 
    at Object.getBranches (/root/strider/node_modules/strider-git/lib/index.js:137:18)

Because, no auth info is initialized. If it's a bug, I'm happy to fix.

@knownasilya

knownasilya commented 8 years ago

Yes. There is a PR in the works, you can contribute here and there https://github.com/Strider-CD/strider/pull/763

msemenistyi commented 7 years ago

+1