search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Someone hit the webhook for 'xxx' and it failed to validate. #10

Closed chevett closed 9 years ago

chevett commented 10 years ago

Strider was really easy to get mostly working! The only issue I'm having is that web hooks from github aren't validating and therefore aren't triggering builds.

I have a server running strider on http://localhost:3000 then I have nginx in front of that handling the ssl at https://ci.miketown3.com.

I'm trying to get notifications from https://github.com/rrrelay/named-logger and it's setup to hit https://ci.miketown3.com/rrrelay/named-logger/api/github/webhook.

In the strider logs, I see

 warn: Someone hit the webhook for rrrelay/named-logger and it failed to validate
POST /rrrelay/named-logger/api/github/webhook 401 55ms - 17b

I've been testing the webhook from the github page and it looks like this... 2014-03-16_2059

I've also created a new github application and set the env variables PLUGIN_GITHUB_APP_ID and PLUGIN_GITHUB_SECRET to the client id and client secret.

Is the payload missing the x-hub-signature header or something? Any help/ideas would be greatly appreciated! Thanks!

freewil commented 10 years ago

What is the response? Does it say 'Invalid Signature'. See #8

chevett commented 10 years ago

Oh super! Thanks a bunch.

chevett commented 10 years ago

ooops, nevermind. It is still not working for me. I took #8 to mean if I deleted and recreated the hooks through the github ui then it would all work. I did that and I'm still getting the 401 Invalid Signature.

chevett commented 10 years ago

ok, the github UI does not work for me. I got it to work by deleting, recreating and then manually setting the config.insecure_ssl to 1 through the github api.

I can't deal with manually doing this for each project, so I hard coded the setting: https://github.com/chevett/strider-github/commit/6e7861af7e40b16fa589defcdefb44f7a85f9807

I was looking for a place in the UI to add a checkbox for this setting, but I couldn't find a place for a global level setting like this. If you guys can point me in the right direction I'd be happy to add this to the UI.

jaredly commented 10 years ago

Are you using strider HEAD? Or the npm version?

On 4/5/14, Mike Chevett notifications@github.com wrote:

ok, the github UI does not work for me. I got it to work by deleting, recreating and then manually setting the config.insecure_ssl to 1 through the github api.

I can't deal with manually doing this for each project, so I hard coded the setting: https://github.com/chevett/strider-github/commit/6e7861af7e40b16fa589defcdefb44f7a85f9807

I was looking for a place in the UI to add a checkbox for this setting, but I couldn't find a place for a global level setting like this. If you guys can point me in the right direction I'd be happy to add this to the UI.

Reply to this email directly or view it on GitHub: https://github.com/Strider-CD/strider-github/issues/10#issuecomment-39638874

chevett commented 10 years ago

I was using the npm version, but now I'm on HEAD. Or really, one commit ahead of HEAD: https://github.com/chevett/strider/commit/6ec657a866fd2512bf28ce0bfbf810aaf4c36af1

I tested the hooks with npm version and couldn't get it to work. So, I forked and added the hard coded insecure_ssl field.

knownasilya commented 9 years ago

@chevett I'm assuming this is still an issue even with the current master version?

chevett commented 9 years ago

I haven't updated in a while, but I can give it a try this afternoon if that's helpful. On Jan 15, 2015 10:28 AM, "Ilya Radchenko" notifications@github.com wrote:

@chevett https://github.com/chevett I'm assuming this is still an issue even with the current master version?

— Reply to this email directly or view it on GitHub https://github.com/Strider-CD/strider-github/issues/10#issuecomment-70102379 .

knownasilya commented 9 years ago

@chevett would be much appreciated! :+1:

chevett commented 9 years ago

There isn't much of an issue here anymore. There was a bug in the github ui that messed up the webhook if you disabled the ssl verification and I have just confirmed that this bug has been fixed by github.

If you have a strider instance that is using a self signed cert, then you have manually disable ssl verification through the github webhook ui and that is working correctly now.