search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Watch out for missing rels in Link header. #12

Closed jdiamond closed 10 years ago

jdiamond commented 10 years ago

Fix for https://github.com/Strider-CD/strider/issues/413.

GitHub is sending Link headers without rel="first" or rel="next" which crashes Strider when you try to refresh your GitHub projects.

The Link header I logged right before the crash only had a rel="last". I don't know if that's just a temporary mistake on GitHub's part, but removing the check for the first link like I did in this pull request prevents Strider from crashing.

I haven't seen any other errors since I made this patch, but I'm new to Strider so might be missing a lot.

niallo commented 10 years ago

Thanks. I believe this is fine. We shouldn't ever care about the 'first' link afaict, so it's safe to ignore. We only care about 'next' For posterity, here are the docs to the Link header: https://developer.github.com/v3/#link-header