search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Fix Webhook payload failed to parse as JSON issue #15

Closed jcope2013 closed 10 years ago

jcope2013 commented 10 years ago

referencing Issue https://github.com/Strider-CD/strider/issues/428#issuecomment-44067451

req.body.payload is showing up as undefined which is causing payload = JSON.parse(req.body.payload) to fail, the correct code should just be payload = req.body and it works fine, req.body at that point has already done JSON.parse(req.body.payload) at some earlier point?

logankoester commented 10 years ago

Tested & confirmed, this resolves the issue for me as well. Thank you!

Would love to see some discussion around merging this change.

niallo commented 10 years ago

Merged, thanks!

logankoester commented 10 years ago

Awesome, thank you!