search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

verify_webhook_req() signature missing #2

Closed morkeleb closed 10 years ago

morkeleb commented 10 years ago

I let strider setup my webooks, yet, they arnt working.

All i get is a log entry stating: verify_webhook_req() signature missing

which doesn't give me much in terms of debugging. Have I missed anything in my setup?

jaredly commented 10 years ago

In order to verify the payload, strider-github checks for the x-hub-signature header on the request. The error indicates that the header isn't there. 1) are you behind any proxies that might strip off the header? 2) are you using github, or github enterprise? 3) try removing the webhooks and re-adding them ("delete service hooks") screenshot from 2013-11-01 15 47 08

niallo commented 10 years ago

Could this be related to https://github.com/Strider-CD/strider/issues/247?source=cc ?

morkeleb commented 10 years ago

I'm behind and nignx https terminating proxy, I've set the proxy_pass_header x-hub-signature; but still no header. Also normal github.

I'm using the npm version of strider, the version you are using seem to be much newer. I can only delete webhooks, the screen your showing has a lot more options.

jaredly commented 10 years ago

Ah yes, thanks for specifying. The npm version is 1.3.5, and the one currently in beta is 1.4. If you want to try it out, grab the github repo of strider; keep in mind that it's not fully polished yet; but from what I can tell, the github webhooks work just fine

Morten Nielsen notifications@github.com wrote:

I'm behind and nignx https terminating proxy, I've set the proxy_pass_header x-hub-signature; but still no header. Also normal github.

I'm using the npm version of strider, the version you are using seem to be much newer. I can only delete webhooks, the screen your showing has a lot more options.

Reply to this email directly or view it on GitHub: https://github.com/Strider-CD/strider-github/issues/2#issuecomment-27618390

Sent from my Android device with K-9 Mail. Please excuse my brevity.

morkeleb commented 10 years ago

I just installed from HEAD... where do you want bug reports? :) BTW- emails started working for me, SMTP_FROM isn't working in the npm version.

morkeleb commented 10 years ago

as mentioned in the new issue, there add remove service hooks buttons doesn't work. I think its because of upgrades and the changed url for the webhooks. I can't test the new setup though, the custom plugin isn't active for some reson, after adding the project as a custom job it wont build at all.

morkeleb commented 10 years ago

I'm now on HEAD 1.4.0-pre. The error message is now gone, however, no webhooks are working. The log doesn't add any lines when I issue a push to the repo, nor when I issue a "test servicehooks" from the github servicehooks page.

morkeleb commented 10 years ago

I've changed the configuration of the VM to allow http traffic. When running using http the webhook works. I think this is related to https terminating in nginx.

jaredly commented 10 years ago

That is really curious.

Morten Nielsen notifications@github.com wrote:

I've changed the configuration of the VM to allow http traffic. When running using http the webhook works. I think this is related to https terminating in nginx.

Reply to this email directly or view it on GitHub: https://github.com/Strider-CD/strider-github/issues/2#issuecomment-27643356

Sent from my Android device with K-9 Mail. Please excuse my brevity.

morkeleb commented 10 years ago

Right, this is an issue with the certificate I used for the HTTPS. Not a problem for strider.

Github aborts all posts when it sees a self-signed certificate.

Here is another post for reference as well: http://www.lukemelia.com/blog/archives/2012/07/07/github-post-receive-hooks-and-ssl-certificates/

niallo commented 10 years ago

Excellent detective work on how GitHub handles a self-signed SSL cert. Thank you!