search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Bugfix: Oauth still breaks without email, prev check to replace with null didn't work #28

Closed SamMorrowDrums closed 9 years ago

SamMorrowDrums commented 9 years ago

Add line to check that the 0 property exists before using it, current version still breaks

Strider-CD/strider#599 Strider-CD/strider#666

I've had confirmation from a colleague that this has fixed the issue, and they have successfully deployed.

knownasilya commented 9 years ago

Thanks @SamMorrowDrums, but this issue was fixed here: https://github.com/Strider-CD/strider-github/commit/9bc4bfa8bcf59f691f08bd45d3be7f868fc735b3

ghost commented 9 years ago

I just ran into this issue. Is https://github.com/Strider-CD/strider-github/commit/9bc4bfa8bcf59f691f08bd45d3be7f868fc735b3 in master? I didn't see it when grepping the log.

knownasilya commented 9 years ago

@talexand it's in strider-github, update it through the plugin manager.