search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Cannot add github repo after upgrade to HEAD of strider #3

Closed morkeleb closed 10 years ago

morkeleb commented 10 years ago

Whenever I try to add anything githuby I get an error page with the following error.

Express 500 failed to fetch user profile (status: 401 data: {"message":"Requires authentication","documentation_url":"http://developer.github.com/v3"}) at /usr/lib/node_modules/strider/node_modules/strider-github/node_modules/passport-github/lib/passport-github/strategy.js:90:28 at passBackControl (/usr/lib/node_modules/strider/node_modules/strider-github/node_modules/passport-github/node_modules/passport-oauth/node_modules/oauth/lib/oauth2.js:105:9) at IncomingMessage. (/usr/lib/node_modules/strider/node_modules/strider-github/node_modules/passport-github/node_modules/passport-oauth/node_modules/oauth/lib/oauth2.js:124:7) at IncomingMessage.EventEmitter.emit (events.js:117:20) at _stream_readable.js:920:16 at process._tickCallback (node.js:415:13)

jaredly commented 10 years ago

If you're willing to dive into mongo, we might get a getter idea of what's going on (I use genghisapp). In the strider-foss database, in the users collection, there should be something like this:

{
    _id: ObjectId("...."),
    account_level: 1,
    accounts: [
        {
            last_updated: ISODate("...."),
            provider: "github",
            id: "....",
            display_url: "https://github.com/jaredly",
            title: "jaredly",
            config: {
                accessToken: "[long hex string]",
                login: "jaredly",
                email: "[your email]",
                gravatarId: "[another hex string]",
                name: "Jared Forsyth"
            },
...

Does that make sense? If the accessToken is there, then try to hit https://api.github.com/user/repos?access_token=[the api token here] in your browser. If that works, then we have some more digging to do....

Also, did strider give you any warnings on startup?

morkeleb commented 10 years ago

The access token is working.

My startup script is depcrated: WARNING: You are using GITHUB_APP_ID to configure Github OAuth application id. This name has been deprecated. Please use PLUGIN_GITHUB_APP_ID instead.

Maybe that warning could be shown for all admins on the main page? Also the GITHUB_APP_ID variable has been renamed but not the GITHUB_APP_SECRET.

jaredly commented 10 years ago

interesting. It was supposed to work even if you used the old vbl names...

morkeleb commented 10 years ago

Maybe I was too fast closing the issue :)