search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

Updated Readme with more complete information on setting custom hostname and port #35

Closed reiven closed 9 years ago

reiven commented 9 years ago

As suggested on #34 i've attached all the needed environment variables to README file, to help new users to correctly use this plugin.

knownasilya commented 9 years ago

On thing I'm not sure about, is if PLUGIN_GITHUB_HOSTNAME is even used. I know it has been brought up. Could you test that, and if it's not needed, remove it from the readme.

reiven commented 9 years ago

You're right, @knownasilya , also "STRIDER_HOSTNAME" variables was not used. Updated

knownasilya commented 9 years ago

Could you squash your commit into something logical? Otherwise looking good!

knownasilya commented 9 years ago

Ops, wrong button haha

knownasilya commented 9 years ago

Some styling issues: https://github.com/reiven/strider-github/blob/master/README.md

reiven commented 9 years ago

Thats weird, if you look https://github.com/reiven/strider-github that "styling" issue is not present Anyway, i can fix it

reiven commented 9 years ago

Done, please check it @knownasilya

knownasilya commented 9 years ago

@reiven could you rebase it? Thanks!

reiven commented 9 years ago

Looks like there is no need. let me know if i'm wrong $ git rebase origin/master Current branch master is up to date. $ git push Everything up-to-date

knownasilya commented 9 years ago

git rebase -i HEAD~[num of commits you made] e.g. git rebase -i HEAD~3

Then use s to squash everything into one commit.

reiven commented 9 years ago

Great , i never used before the rebase-squash things. :+1: Thanks!

knownasilya commented 9 years ago

Glad you got it working, thanks for hanging in there with me :smile: