search

Strider-CD / strider-github

Github provider for strider
25 stars 34 forks source link

add remove service hooks buttons does nothing #4

Closed morkeleb closed 10 years ago

morkeleb commented 10 years ago

There is no feedback when pressing the buttons, nor do they do anything in the github repo.

After removing and adding the project again I can however mention that the webhook url is significantly changed.

morkeleb commented 10 years ago

This could be caused by the javascript error I reported at the strider repo. It's on the same page.

Error: [ng:areq] Argument 'GithubCtrl' is not a function, got undefined http://errors.angularjs.org/1.2.0-rc.2/ng/areq?p0=GithubCtrl&p1=not%20a%20function%2C%20got%20undefined at https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:78:12 at assertArg (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:1215:11) at assertArgFn (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:1225:3) at https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:5580:9 at https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:5093:34 at forEach (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:231:20) at nodeLinkFn (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:5080:11) at compositeLinkFn (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:4640:15) at nodeLinkFn (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:5115:24) at compositeLinkFn (https://cuttime-builder.cloudapp.net/javascripts/lib/angular.js:4640:15) angular.js:7861

jaredly commented 10 years ago

ah yes. that definitely shouldn't happen.

morkeleb commented 10 years ago

This was due to missing write access to the public directory in the node_module.